Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate InputPassword to MUI #1829

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from
Open

Conversation

lucaslobatob
Copy link
Collaborator

Description

This PR was made to migrate InputPassword to the MUI library, where we changed the main InputPassword.tsx file and styled it in two files where it is called to change the styling, they are SignUpForm.tsx and OryProfileView.tsx.

Fixes #1512

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

1. Log in to the platform;
2. Click on the avatar in the upper right corner;
3. Click on Log in or Register;
4. Test the password field;
5. Once logged in, to change the password, repeat the same process and click on My Account.

Login Page
Before:
Screenshot from 2025-02-19 15-27-29
After:
Screenshot from 2025-02-20 11-30-46
Screenshot from 2025-02-20 11-30-37

Register Page
Before:
Screenshot from 2025-02-19 15-27-04
After:
Screenshot from 2025-02-20 11-34-08

Password Change Page
Before:
Screenshot from 2025-02-20 11-39-18
After:
Screenshot from 2025-02-20 11-40-16

Developer Checklist

General

  • No console.log or related logging is added.

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

}

::placeholder {
color: ${colors.blackSecondary};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the colors relevant in this exchange? If not, what was the reason for their removal?


input {
background: ${colors.lightNeutral};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the colors relevant in this exchange? If not, what was the reason for their removal?

}

:focus {
border: none;
box-shadow: 0px 2px 2px ${colors.shadow};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@lucaslobatob
Copy link
Collaborator Author

@Keikonichi the removal of colors and placeholder and focus is because there was no visual difference as they were not being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Migrate component InputPassword.tsx - Import { Input }
2 participants