-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate InputPassword to MUI #1829
base: stage
Are you sure you want to change the base?
Conversation
} | ||
|
||
::placeholder { | ||
color: ${colors.blackSecondary}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the colors relevant in this exchange? If not, what was the reason for their removal?
|
||
input { | ||
background: ${colors.lightNeutral}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the colors relevant in this exchange? If not, what was the reason for their removal?
} | ||
|
||
:focus { | ||
border: none; | ||
box-shadow: 0px 2px 2px ${colors.shadow}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
@Keikonichi the removal of colors and placeholder and focus is because there was no visual difference as they were not being used |
Description
This PR was made to migrate InputPassword to the MUI library, where we changed the main
InputPassword.tsx
file and styled it in two files where it is called to change the styling, they areSignUpForm.tsx
andOryProfileView.tsx
.Fixes #1512
Type of change
Testing
1. Log in to the platform;
2. Click on the avatar in the upper right corner;
3. Click on Log in or Register;
4. Test the password field;
5. Once logged in, to change the password, repeat the same process and click on My Account.
Login Page



Before:
After:
Register Page


Before:
After:
Password Change Page


Before:
After:
Developer Checklist
General
console.log
or related logging is added.Frontend Changes
Tests
Merge Request Review Checklist