Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timezone and locale description #110

Merged
merged 4 commits into from
Jan 22, 2025
Merged

add timezone and locale description #110

merged 4 commits into from
Jan 22, 2025

Conversation

YuliyaPoznyak
Copy link
Collaborator

No description provided.

Copy link
Contributor

@georged georged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuliyaPoznyak you added timezone and locale in the wrong place. Should be the list of properties. You can add an example of using user.timezone to convert a random date eg "now" to user's timezone.

https://docs.alexacrm.com/twig/introduction/#access-the-current-user-record

Copy link
Contributor

@georged georged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuliyaPoznyak

  • timezone-- Overrides the date using the current user's timezone.
  • locale -- Overrides the date using the current user's locale.

This is wrong. These properties do not override anything, they simply return timezone or locale for the current user. You need to explain what format do they return the information in (e.g. IANA timezone, etc, maybe even point to the public source like https://en.wikipedia.org/wiki/List_of_tz_database_time_zones and its locale equivalent) and provide a sample of a return value, e.g. "Australia/Sydney"

You also need to assert if they can be null.

@YuliyaPoznyak YuliyaPoznyak requested a review from georged January 21, 2025 13:16
@YuliyaPoznyak
Copy link
Collaborator Author

@georged I changed the description for the timezones, created a new page to display individual field types using twig (to make the pages more related in meaning), added the description from the tasks from the board there (based on how it currently works). I can move some of the material to KB or break the new page into separate articles.

@georged georged merged commit 30f58dd into master Jan 22, 2025
1 check passed
@georged georged deleted the fix12748 branch January 22, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants