-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-6125: test support for path queries against categories #2602
Conversation
// then | ||
STEP("Verify that searching by PATH for nested folder will return no results (Dependency to category is not transitive)"); | ||
SearchRequest query = req(format("PATH:'/cm:categoryRoot/cm:generalclassifiable/cm:%s/cm:%s/cm:%s/cm:%s'", Kname, Lname, Aname, Bname)); | ||
searchQueryService.expectResultsFromQuery(query, testUser); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a expectNoResultsFromQuery
method that you can use for this.
...earch/src/test/java/org/alfresco/elasticsearch/reindexing/NodeWithCategoryIndexingTests.java
Outdated
Show resolved
Hide resolved
...earch/src/test/java/org/alfresco/elasticsearch/reindexing/NodeWithCategoryIndexingTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few trivial things, but LGTM 👍
…ch/reindexing/NodeWithCategoryIndexingTests.java Co-authored-by: Tom Page <[email protected]>
…ch/reindexing/NodeWithCategoryIndexingTests.java Co-authored-by: Tom Page <[email protected]>
5373e08
to
f68b8da
Compare
# Conflicts: # tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/NodeWithCategoryIndexingTests.java # tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Categories.java # tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Category.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PMD found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
No description provided.