Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-30141 Replace ngIf for asterix with style visibility #10665

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

tomson7777
Copy link
Contributor

@tomson7777 tomson7777 commented Feb 20, 2025

JIRA TICKET: https://hyland.atlassian.net/browse/AAE-30141

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

Why NgIf is removed and vislibility is used - *ngIf removes node from HTML, and visiblity hidden keeps element in HTML.
So previously , if form element was used in table, it was not aligned with elements which are not required.
Now, controls in tables are aligned

Does this PR introduce a breaking change? (check one with "x")

  • [] Yes
  • No

@tomson7777 tomson7777 merged commit ac11fa8 into develop Feb 25, 2025
18 checks passed
@tomson7777 tomson7777 deleted the feature/AAE-30141-asterix branch February 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants