Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartesian transformations between acsets #899

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Conversation

KevinDCarlson
Copy link
Contributor

You can check for cartesian morphisms now! Just go like

is_cartesian(f,[h_1,h_2])

where h_i == (name_i,src_i,tgt_i) are triples of homs in the acset schema for the domain and codomain of f.

@epatters
Copy link
Member

epatters commented Apr 18, 2024

Hey, this is great! Thanks Kevin.

CC @slwu89

@epatters epatters changed the title Cartesian morphisms Cartesian transformations between acsets Apr 18, 2024
@slwu89
Copy link
Member

slwu89 commented Apr 18, 2024

Amazing!! Looks like there's no new actual test in the new tests though, maybe they slipped out of the last commit?

@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Apr 23, 2024
src/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
src/categorical_algebra/Limits.jl Outdated Show resolved Hide resolved
@KevinDCarlson
Copy link
Contributor Author

OK, both handled.

@epatters
Copy link
Member

Looks like tests are failing. Also, the docstring for is_cartesian should be updated to reflect your latest changes.

@KevinDCarlson
Copy link
Contributor Author

whoops, fixed

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin!

@epatters epatters merged commit 4b796bc into main Apr 24, 2024
10 checks passed
@epatters epatters deleted the cartesian_morphisms branch April 24, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants