Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown ordered list numbering #4989

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Fix markdown ordered list numbering #4989

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ba3856
fix: preserve starting numbers in markdown ordered lists
openhands-agent Nov 13, 2024
c371384
fix: update ordered list component to use explicit start prop
openhands-agent Nov 13, 2024
ca5b9ab
fix: use correct HTML element types for list components
openhands-agent Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/src/components/markdown/list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@
// Custom component to render <ol> in markdown
export function ol({
children,
...props
}: React.ClassAttributes<HTMLElement> &
React.HTMLAttributes<HTMLElement> &
ExtraProps) {
return (
<ol className="list-decimal ml-5 pl-2 whitespace-normal">{children}</ol>
<ol className="list-decimal ml-5 pl-2 whitespace-normal" {...props}>

Check failure on line 21 in frontend/src/components/markdown/list.tsx

View workflow job for this annotation

GitHub Actions / Lint frontend 

Prop spreading is forbidden
{children}
</ol>
);
}
Loading