Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown ordered lists counter reset #4990

Closed
wants to merge 2 commits into from

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 14, 2024

This PR fixes the issue where markdown ordered lists were not incrementing numbers correctly. The fix adds a counterReset: "list-item" style to ensure each ordered list starts with a fresh counter.

Changes:

  • Added style={{ counterReset: "list-item" }} to the ordered list component
  • Maintains existing spacing and styling

Before:
All list items showed as "1." instead of incrementing numbers.

After:
List items now correctly show as "1.", "2.", "3.", etc.

Note on Tests:
Some tests are failing due to missing i18n declarations, which is a separate issue with the test environment setup. These failures are unrelated to our changes since we only modified the markdown list component and its styling.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:fd6820f-nikolaik   --name openhands-app-fd6820f   docker.all-hands.dev/all-hands-ai/openhands:fd6820f

@rbren
Copy link
Collaborator Author

rbren commented Nov 14, 2024

Whoops this was a demo

@rbren rbren closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants