Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the ValueErrors raised by the euclidean generator messages #396

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

chrisib
Copy link
Collaborator

@chrisib chrisib commented Dec 4, 2024

This gives better feedback for debugging

@chrisib chrisib added firmware Software related issue improvement Improvement or optimization of an existing feature or script labels Dec 4, 2024
@chrisib
Copy link
Collaborator Author

chrisib commented Jan 8, 2025

I'm making the executive decision to merge this without review since it's purely a debugging fix that won't have any impact on performance under normal conditions; it just provides better feedback on an error.

@chrisib chrisib merged commit 8924ba2 into Allen-Synthesis:main Jan 8, 2025
3 checks passed
@chrisib chrisib deleted the better-euclid-errors branch January 8, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firmware Software related issue improvement Improvement or optimization of an existing feature or script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant