Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Deprecate subtypes of BrainInjection? #1233

Open
dbirman opened this issue Jan 14, 2025 · 1 comment
Open

[2.0] Deprecate subtypes of BrainInjection? #1233

dbirman opened this issue Jan 14, 2025 · 1 comment
Assignees
@dbirman
Labels
breaking Breaking changes
Milestone
data-schema 2.0 a...

Comments

@dbirman
Copy link
Member

dbirman commented Jan 14, 2025

Some of the BrainInjection sub-classes are identical, e.g. IntraCerebellarVentricleInjection and IntraCisternalMagnaInjection. These should probably be deprecated and removed in favor of having a BrainInjection target field that takes a structure name as input.
@dbirman dbirman added this to the v2.0 milestone Jan 14, 2025
@dbirman dbirman added the breaking Breaking changes label Jan 15, 2025
@dbirman
Copy link
Member Author

dbirman commented Jan 16, 2025

Blocked by #1187, BrainInjection should be refactored to use the new coordinate system classes

@dbirman dbirman self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbirman dbirman

Labels
breaking Breaking changes
Projects
None yet
Milestone
data-schema 2.0 and data-schema-model...
Development

When branches are created from issues, their pull requests are automatically linked.

1233-20-deprecate-subtypes-of-braininjection AllenNeuralDynamics/aind-data-schema
1 participant
@dbirman