Respond with unsupported message when GetBucketLocation

Cherry-pick of existing commit. orig-pr: #18416 orig-commit: d8fdcb5 orig-commit-author: yuyang wang <[email protected]> pr-link: #18432 change-id: cid-05c70148361e293e6583ddb6abda93eb2c530496
Alluxio · Nov 22, 2023 · b6f99f6 · b6f99f6
1 parent c3ce6aa
commit b6f99f6
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/core/server/proxy/src/main/java/alluxio/proxy/s3/S3RestServiceHandler.java b/core/server/proxy/src/main/java/alluxio/proxy/s3/S3RestServiceHandler.java
@@ -287,6 +287,7 @@ public Response headBucket(
    * @param acl query string to indicate if this is for GetBucketAcl
    * @param policy query string to indicate if this is for GetBucketPolicy
    * @param policyStatus query string to indicate if this is for GetBucketPolicyStatus
+   * @param location query parameter to indicate if this is for GetBucketLocation
    * @param uploads query string to indicate if this is for ListMultipartUploads
    * @return the response object
    */
@@ -306,6 +307,7 @@ public Response getBucket(@HeaderParam("Authorization") final String authorizati
                             @QueryParam("acl") final String acl,
                             @QueryParam("policy") final String policy,
                             @QueryParam("policyStatus") final String policyStatus,
+                            @QueryParam("location") final String location,
                             @QueryParam("uploads") final String uploads) {
     return S3RestUtils.call(bucket, () -> {
       Preconditions.checkNotNull(bucket, "required 'bucket' parameter is missing");
@@ -327,6 +329,12 @@ public Response getBucket(@HeaderParam("Authorization") final String authorizati
             "GetBucketpolicyStatus is not currently supported.",
             S3ErrorCode.INTERNAL_ERROR.getStatus()));
       }
+      if (location != null) {
+        throw new S3Exception(bucket, new S3ErrorCode(
+            S3ErrorCode.NOT_IMPLEMENTED.getCode(),
+            "GetBucketLocation is not currently supported.",
+            S3ErrorCode.NOT_IMPLEMENTED.getStatus()));
+      }
 
       String path = S3RestUtils.parsePath(AlluxioURI.SEPARATOR + bucket);
       final String user = getUser(authorization);