disallow duplicate workers

Alluxio · Nov 30, 2023 · d93f454 · d93f454
1 parent 0fd41af
commit d93f454
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/dora/core/common/src/main/java/alluxio/membership/WorkerClusterView.java b/dora/core/common/src/main/java/alluxio/membership/WorkerClusterView.java
@@ -50,7 +50,13 @@ public WorkerClusterView(Iterable<WorkerInfo> workers) {
   WorkerClusterView(Iterable<WorkerInfo> workers, Instant createdTime) {
     mWorkers = Streams.stream(workers)
         .collect(ImmutableMap.toImmutableMap(
-            WorkerInfo::getIdentity, Function.identity(), (first, second) -> second));
+            WorkerInfo::getIdentity,
+            Function.identity(),
+            (first, second) -> {
+              throw new IllegalArgumentException(
+                  String.format("duplicate workers with the same ID: first: %s, second: %s",
+                      first, second));
+            }));
     // Note Instant.now() uses the system clock and is NOT monotonic
     // which is fine because we want to invalidate stale snapshots based on wall clock time
     mInstantCreated = createdTime;

diff --git a/dora/core/common/src/test/java/alluxio/membership/WorkerClusterViewTest.java b/dora/core/common/src/test/java/alluxio/membership/WorkerClusterViewTest.java
@@ -65,9 +65,9 @@ public void keyedByWorkerId() {
         .setAddress(new WorkerNetAddress().setHost("host2"));
     WorkerInfo worker3 = new WorkerInfo().setIdentity(id)
         .setAddress(new WorkerNetAddress().setHost("host3"));
-    WorkerClusterView view = new WorkerClusterView(ImmutableList.of(worker1, worker2, worker3));
-    assertEquals(1, view.size());
-    assertEquals(Optional.of(id), view.getWorkerById(id).map(WorkerInfo::getIdentity));
+    List<WorkerInfo> workers = ImmutableList.of(worker1, worker2, worker3);
+    assertThrows("duplicate workers not allowed", IllegalArgumentException.class,
+        () -> new WorkerClusterView(workers));
   }
 
   @Test