Add regx pattern file filter for distributed load #18311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiamingMai
force-pushed
the
add-regx-pattern-file-filter
branch
from
332ad1a to
1b8a977
Compare
jja725
suggested changes
Oct 23, 2023
| @@ -60,11 +62,23 @@ public Job<?> create() { | |||
| .ofNullable(AuthenticatedClientUser.getOrNull()) | |||
| .map(User::getName); | |||
|
|
|||
| Predicate<UfsStatus> predicate = Predicates.alwaysTrue(); | |||
There was a problem hiding this comment.
These logic should also appear at JournaledLoadJobFactory so we can recover from journal entry
There was a problem hiding this comment.
Updated. I put these logic into JournaledLoadJobFactory.
| UnderFileSystem ufs = mFs.getUfsManager().getOrAdd(new AlluxioURI(path), | ||
| UnderFileSystemConfiguration.defaults(Configuration.global())); | ||
| Iterable<UfsStatus> iterable = new UfsStatusIterable(ufs, path, | ||
| Optional.ofNullable(AuthenticatedClientUser.getOrNull()).map(User::getName), | ||
| Predicates.alwaysTrue()); | ||
| predicate); | ||
| return new DoraLoadJob(path, user, UUID.randomUUID().toString(), bandwidth, partialListing, |
There was a problem hiding this comment.
We also want to put this filter information into DoraLoadJob so we can turn this job into a journal entry.
JiamingMai
force-pushed
the
add-regx-pattern-file-filter
branch
from
1409f44 to
598f723
Compare
Updated. Tests are added in |
# Conflicts: # dora/core/server/master/src/main/java/alluxio/master/job/JournalLoadJobFactory.java
jja725
reviewed
Oct 26, 2023
jja725
reviewed
Oct 26, 2023
| Thread.sleep(1000); | ||
| } | ||
| assertTrue(mOutput.toString().contains("Inodes Processed: 1")); | ||
| } |
There was a problem hiding this comment.
verify only B is loaded, not A&C
JiamingMai
force-pushed
the
add-regx-pattern-file-filter
branch
from
4e3efab to
ad2ac8b
Compare
|
alluxio-bot, merge this please |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
Add regx pattern file filter for distributed load. **Example:** The following request allows us to load the files under `/test-load` directory with "hello" prefix: `curl -X GET http://localhost:28080/v1/load?path=s3a://jiamingmai-test/test-load&opType=submit&verbose=true&fileFilterRegx=^hello.*` pr-link: Alluxio#18311 change-id: cid-4ec2bfe58bfba413f6d2925f5b3937bd6f5c2eb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regx pattern file filter for distributed load.
Example:
The following request allows us to load the files under
/test-loaddirectory with "hello" prefix:curl -X GET http://localhost:28080/v1/load?path=s3a://jiamingmai-test/test-load&opType=submit&verbose=true&fileFilterRegx=^hello.*