Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UfsUrlBench #18345

Open
wants to merge 100 commits into
base: use-ufs-path
Choose a base branch
from
Open

Add UfsUrlBench #18345

wants to merge 100 commits into from

Conversation

YichuanSun
Copy link
Contributor

What changes are proposed in this pull request?

Add microbench of UfsUrl. it is part of a huge PR. This PR only contains the microbench.

Why are the changes needed?

To quantify the performance of Url

Does this PR introduce any user facing changes?

no.

jiacheliu3 and others added 30 commits June 14, 2023 14:47
@jiacheliu3
an example implementation purely to measure the amount of effort to c…
c5f0a15 
…hange the API
@jiacheliu3
add a wrapper
ef0c2da
@jiacheliu3
add new class
2f2d3da
@YichuanSun
Add refactor of openFile, and other small fix.
781132f
@YichuanSun
Add the refactor of ls test. Add part of ctor of UfsUrl.java.
7d7f206
@YichuanSun
Add part of UfsUrl.java, add a little part of UfsUrlTest.java.
c762773
@YichuanSun
Add ls command refactor version.
6bf1897
@YichuanSun
fix the double slash dir bug.
5b320a9
@YichuanSun
a backup for further refactor. Next try to solve the root dir problem.
d3dc6dd
@YichuanSun
Refactor part of UfsUrl, add method "isAncestorOf".
d1477b1
@YichuanSun
Only contain the UfsUrl design.
2a00bd9
@YichuanSun
Cherry-pick from the UfsUrl data structure design branch.
8be2a8d
@YichuanSun
Leave only one todo of Tony Sun in UfsUrl.java, add a field mDepth to…
16e64c3 
… represent path depth.
@YichuanSun @jiacheliu3
Update dora/core/client/fs/src/main/java/alluxio/client/file/BaseFile…
90e0d35 
…System.java

Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun
Delete useless comments and resolved todo. Delete UfsUrlUtils.java fo…
a6f07bb 
…r it is not be used.
@YichuanSun
Cherry-pick from UfsUrl design branch: Delete useless comments and re…
ce37d65 
…solved todo. Delete UfsUrlUtils.java for it is not be used.
@YichuanSun
Merge branch 'ufs-url-yichuan-UfsUrl' of https://github.com/YichuanSu…
bcf4316 
…n/alluxio into ufs-url-yichuan-UfsUrl

Merge from remote rebased branch.
@YichuanSun
Bug is still exist.
0966942
@YichuanSun
extract the modification of mine from the merge commit.
17ecf49
@YichuanSun
Cherry-pick from today's change.
a8cc11a
@YichuanSun
A primary version of UfsUrl.java.
c653ffe
@YichuanSun
Add static factory method, refactor ctor of UfsUrl.
6de92c3
@YichuanSun
Add static factory method, refactor ctor of UfsUrl. A primary full ve…
3a59a21 
…rsion of UfsUrl and ls command.
@YichuanSun
First review of myself, remove redundant comments and finished todo, …
d88c816 
…fix some logic bug in UfsUrl.createInstance.
@YichuanSun @jiacheliu3
Update dora/core/client/fs/src/main/java/alluxio/client/file/DoraCach…
6efb017 
…eFileSystem.java

Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun @jiacheliu3
Update dora/core/common/src/main/java/alluxio/util/UfsUrlUtils.java
a4a5359 
Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun @jiacheliu3
Update dora/core/common/src/main/java/alluxio/uri/UfsUrl.java
96cce95 
Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun @jiacheliu3
Update dora/core/common/src/main/java/alluxio/uri/UfsUrl.java
3eedfa7 
Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun @jiacheliu3
Update dora/core/common/src/main/java/alluxio/uri/UfsUrl.java
2f8fca5 
Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun @jiacheliu3
Update dora/core/common/src/main/java/alluxio/uri/UfsUrl.java
9ffeb33 
Co-authored-by: Jiacheng Liu <[email protected]>
@YichuanSun
fix the empty scheme and alluxio scheme cases in all ctors of UfsUrl
844b9cd
@YichuanSun
remove useless mRootUfsUrl field in UfsBaseFileSystem
9be69f2
@YichuanSun
solve the latest comments.
26f2bc9
@YichuanSun
solve rebase conflict...
fc2be91
@YichuanSun
rebase to add UfsUrl design.
4066457
@YichuanSun
rebasing with ufs-url-yichuan-UfsUrl
1a56e01
@YichuanSun
tmp save.
e33acd8
@YichuanSun
add all UT of UfsUrl
bcc8548
@YichuanSun
merge and resolve conflicts with the remote branch
df5b7a3
@YichuanSun
rename some methods
90a1202
@YichuanSun
fix checkstyle
62ed832
@YichuanSun
performance improvement.
72597b0
@YichuanSun
pre assign StringBuilder
8aea3d2
@YichuanSun
handle some todos in the UfsUrl.java
3987848
@YichuanSun
Add all UT of UfsUrl.java, refactor UfsUrl.joinUnsafe
d435333
@YichuanSun
refactor path normalization function
7f25ab5
@YichuanSun
refactor removeRedundantSlashes
27235d7
@YichuanSun
Replace java.net.uri with FilenameUtils and add comments
ab107b9
@YichuanSun
replace ExpectedException with assertThrow, and other small fix.
00c2d3e
@YichuanSun
remove the suuport of "." and ".." parsing.
3bf56a8
@YichuanSun
fix checkstyle.
1e12393
@YichuanSun
refactor Parser ctor, add a test case.
0847301
@YichuanSun
getParentURL now returns Optional.
e3f95ef
@YichuanSun
update
b7d7751
@YichuanSun
fix checkstyle.
3cf8ee1
@YichuanSun
remove useless case
fddec47
@YichuanSun
Isolate the enrichment of UfsUrlBench
a2a01ad
@YichuanSun YichuanSun added the type-feature This issue is a feature request label Oct 30, 2023
@YichuanSun YichuanSun self-assigned this Oct 30, 2023
@YichuanSun YichuanSun requested a review from jiacheliu3 October 30, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacheliu3 jiacheliu3 Awaiting requested review from jiacheliu3

Assignees

@YichuanSun YichuanSun

Labels
type-feature This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YichuanSun @jiacheliu3