Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isAllPageCached #18347

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

elega
Copy link
Contributor

@elega elega commented Oct 31, 2023

What changes are proposed in this pull request?

Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not.

Why are the changes needed?

Bug fixing

Does this PR introduce any user facing changes?

N/A

Copy link
Contributor

@dbw9580 dbw9580 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elega elega added the type-bug This issue is about a bug label Oct 31, 2023
@elega
Copy link
Contributor Author

elega commented Oct 31, 2023

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit ec4868d into Alluxio:main Oct 31, 2023
12 checks passed
@elega
Copy link
Contributor Author

elega commented Nov 2, 2023

alluxio-bot, cherry-pick this to branch-3-1.1.x please.

@alluxio-bot
Copy link
Contributor

Auto cherry-pick to branch branch-3-1.1.x successfully opened PR: #18354

alluxio-bot pushed a commit that referenced this pull request Nov 2, 2023
### What changes are proposed in this pull request?

Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not.

### Why are the changes needed?

Bug fixing 

### Does this PR introduce any user facing changes?

N/A
			pr-link: #18347
			change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
alluxio-bot added a commit that referenced this pull request Nov 2, 2023
Cherry-pick of existing commit.
orig-pr: #18347
orig-commit: ec4868d
orig-commit-author: elega <[email protected]>

			pr-link: #18354
			change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
### What changes are proposed in this pull request?

Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not.

### Why are the changes needed?

Bug fixing 

### Does this PR introduce any user facing changes?

N/A
			pr-link: Alluxio#18347
			change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants