-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isAllPageCached #18347
Merged
Merged
Fix isAllPageCached #18347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbw9580
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alluxio-bot, merge this please. |
alluxio-bot, cherry-pick this to branch-3-1.1.x please. |
Auto cherry-pick to branch |
alluxio-bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
### What changes are proposed in this pull request? Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not. ### Why are the changes needed? Bug fixing ### Does this PR introduce any user facing changes? N/A pr-link: #18347 change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
alluxio-bot
added a commit
that referenced
this pull request
Nov 2, 2023
Cherry-pick of existing commit. orig-pr: #18347 orig-commit: ec4868d orig-commit-author: elega <[email protected]> pr-link: #18354 change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not. ### Why are the changes needed? Bug fixing ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#18347 change-id: cid-da4bdce6615e4b1d9777a98ab335bf36e503d102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix a bug when file size < 1 page, alluxio considers all pages are cached no matter if it really caches it or not.
Why are the changes needed?
Bug fixing
Does this PR introduce any user facing changes?
N/A