Fix integration tests again #18392
Merged
Fix integration tests again #18392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YichuanSun
approved these changes
Nov 8, 2023
|
alluxio-bot, merge this please |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
a previous PR Alluxio#18313 restored the integration tests but caused the unit tests to also run with the integration tests. the issue was correctly identified as an issue with the maven project list but the underlying problem was that the project name was not correctly set; `dora/tests` is not a module. it was previously a module until `dora/tests/testcontainers` was introduced, thus separating testcontainer tests vs integration tests. this fix updates the previous project list with the correct module name pr-link: Alluxio#18392 change-id: cid-5f899f224abfbea4b7608d72cc2d38fed6449836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a previous PR #18313 restored the integration tests but caused the unit tests to also run with the integration tests.
the issue was correctly identified as an issue with the maven project list but the underlying problem was that the project name was not correctly set;
dora/testsis not a module. it was previously a module untildora/tests/testcontainerswas introduced, thus separating testcontainer tests vs integration tests.this fix updates the previous project list with the correct module name