Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the active rpc metrics; Port [#17234] to branch-2.10 #18587

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix the active rpc metrics; Port [#17234] to branch-2.10 #18587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bff1b5
cp without resolving conflicts
Kai-Zhang May 6, 2023
c842053
resolve conflict and compare with code in master-2.x
Xenorith Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions core/server/worker/src/main/java/alluxio/worker/grpc/BlockReadHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,29 +464,30 @@ private void runInternal() {
}
continue;
}
if (error != null) {
if (eof || cancel || error != null) {
try {
completeRequest(mContext, false);
} catch (Exception e) {
LOG.error("Failed to close the request.", e);
}
replyError(error);
} else if (eof || cancel) {
try {
boolean success = !cancel;
boolean success = !cancel && error == null;
completeRequest(mContext, success);
} catch (Exception e) {
LogUtils.warnWithException(LOG, "Exception occurred while completing read request, "
+ "EOF/CANCEL sessionId: {}. {}", mContext.getRequest().getSessionId(),
mContext.getRequest(), e);
setError(new Error(AlluxioStatusException.fromThrowable(e), true));
if (error != null) {
LOG.error("Failed to close the request.", e);
} else {
LogUtils.warnWithException(LOG, "Exception occurred while completing read request, "
+ "EOF/CANCEL sessionId: {}. {}", mContext.getRequest().getSessionId(),
mContext.getRequest(), e);
error = new Error(AlluxioStatusException.fromThrowable(e), true);
}
}
if (eof) {
if (error != null) {
replyError(error);
} else if (eof) {
replyEof();
} else {
} else if (cancel) {
replyCancel();
}
}
// Leave `!mResponse.isReady() && tooManyPendingChunks()` unhandled
// since the reader is not finished in that case and needs more rounds
}

/**
Expand Down
Loading