http/tcp: remove reject listener on success.

AlphaStaxLLC · Jul 23, 2017 · 906a6bf · 906a6bf
1 parent c347add
commit 906a6bf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/lib/http/base.js b/lib/http/base.js
@@ -811,15 +811,13 @@ HTTPBase.prototype.address = function address() {
 
 HTTPBase.prototype.listen = function listen(port, host) {
   return new Promise((resolve, reject) => {
-    let addr;
-
-    this.server.once('error', reject)
-
+    this.server.once('error', reject);
     this.server.listen(port, host, () => {
-      addr = this.address();
+      let addr = this.address();
 
       this.emit('listening', addr);
 
+      this.server.removeListener('error', reject);
       resolve(addr);
     });
   });

diff --git a/lib/net/tcp.js b/lib/net/tcp.js
@@ -41,8 +41,11 @@ tcp.createServer = function createServer() {
 
   ee.listen = function listen(port, host) {
     return new Promise((resolve, reject) => {
-      server.once('error', reject)
-      server.listen(port, host, resolve);
+      server.once('error', reject);
+      server.listen(port, host, () => {
+        server.removeListener('error', reject);
+        resolve();
+      });
     });
   };