remove all duplicated logic, move all macroses and query parsing functionality to golang, and compile golang parser to WASM #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/datasource/frontend-only/sql-series/toAnnotation.test.ts # src/datasource/sql-query/sql-query-macros.ts # src/datasource/sql-query/sql_query.ts # src/spec/query_specs.jest.ts # src/spec/sql_series_specs.jest.ts
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
|
git checkout v4
git pull origin v4
docker compose up -d grafanawhy $from and $to didn't replace? |
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Slach
requested changes
Feb 7, 2025
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Slach
requested changes
Mar 3, 2025
| # "/Grafana Datasource Plugin For Clickhouse/e2e/many categories/*": [ | ||
| # (Fail, "Waiting for the fix https://github.com/Altinity/clickhouse-grafana/issues/705") | ||
| # ], | ||
| "/Grafana Datasource Plugin For Clickhouse/e2e/many categories/*": [ |
There was a problem hiding this comment.
but we resolved issue?, we need to comment it
| @@ -225,40 +225,10 @@ def annotations_without_time_reformatting(self): | |||
| with delay(): | |||
| assert actions.compare_screenshots_percent(screenshot_name_1="event_tme_panel", screenshot_name_2="toUInt64_panel") > 0.9, error() | |||
|
|
|||
|
|
|||
| @TestScenario | |||
| def many_categories(self): | |||
There was a problem hiding this comment.
wrong way, why we remove tests?
| @@ -31,7 +31,7 @@ def function_check(self, query, expected_reformatted_query): | |||
|
|
|||
| with Then("I check reformatted query"): | |||
| with delay(): | |||
| assert expected_reformatted_query in sql_editor.get_reformatted_query(query_name='A'), error() | |||
| assert expected_reformatted_query.replace("\n", "") in sql_editor.get_reformatted_query(query_name='A'), error() | |||
There was a problem hiding this comment.
maybe space instead of empty line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #688