-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created remember the last used folder option #57
created remember the last used folder option #57
Conversation
Hello @AmrDeveloper I've implemented the requested feature, so please check it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me everything is good, just need to make two small changes
app/src/main/res/values/strings.xml
Outdated
@@ -31,6 +31,7 @@ | |||
<string name="import_export_choose_file_type">Choose a file type</string> | |||
<string name="password">Password</string> | |||
<string name="enable_password">Enable password</string> | |||
<string name="default_folder">Remember the last used folder as default one</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find translations for other langs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I use google translate to translate this line to all the other languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I use google translate to translate this line to all the other languages?
For now yes, and can we make it shorter than Remember the last used folder as default one
, hmmm maybe Enable Remember Folder
or Remember last folder
what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what's right, "Remember the last folder" in my opinion would be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great let's go with it
@@ -55,6 +55,9 @@ class SettingFragment : Fragment() { | |||
|
|||
// Setup Auto saving | |||
binding.autoSavingSwitch.isChecked = uiPreferences.isAutoSavingEnabled() | |||
|
|||
// Setup Auto saving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, Fix this comment to be // Setup default folder
Hello, @AmrDeveloper, I've resolved the commented changes . So please check it out |
Looks great, Thank you |
Remember the last used folder when adding new link option