Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#223 - Remove the generic block identifier #222

Merged
merged 2 commits into from
Mar 4, 2024
Merged

#223 - Remove the generic block identifier #222

merged 2 commits into from
Mar 4, 2024

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Mar 4, 2024

Description

Removes the GenericBlockIdentifier, and is not required to expose it to the wallet api.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Lohann Lohann requested review from dvc94ch and ManojJiSharma March 4, 2024 13:32
@Lohann Lohann linked an issue Mar 4, 2024 that may be closed by this pull request
Cleanup rosetta-client interface #223
Closed
@Lohann Lohann changed the title Remove the generic block identifier #223 - Remove the generic block identifier Mar 4, 2024
@Lohann Lohann merged commit 7221619 into master Mar 4, 2024
8 checks passed
@Lohann Lohann deleted the refactor/remove-generic-block-identifier branch March 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvc94ch dvc94ch dvc94ch approved these changes

@ManojJiSharma ManojJiSharma Awaiting requested review from ManojJiSharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup rosetta-client interface
2 participants
@Lohann @dvc94ch