You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request fixes issue #38 by making several changes to the RequestForm component. The changes include removing unused files, refactoring the component, adding missing pages, updating dependencies, and improving form layout and validation. These changes enhance the functionality and user experience of the request form.
Type
enhancement, documentation
Description
Added a new FoodDeliveryForm.vue component with dark mode support.
Removed unused RequestForm.vue and FoodRequestForm.vue components.
Updated dashboard layout with new icons and added a settings page link.
Updated the dashboard index page to include a new request form and request history.
Added a new settings page for portal settings including theme customization.
Added test cases for the dashboard index page.
Added FoodDeliveryFormState interface for the new food delivery form component.
Added type declaration for @vueform/plugin-mask.
Configured Vueform with the mask plugin and added @vueform/plugin-mask dependency.
Updated lock file with new dependencies.
Added JSON data for branch locations, countries, divisions level1, and languages for the food delivery form.
- Delete unused step schema and logic from RequestForm
- Extract shared form elements into separate schema
- Add styling to customize form theme
- Update example dashboard page to demonstrate usage
- Rename page# ids to step# for clarity
- Add static section headers to indicate each step
- Set Province/Territory field as required
- Adjust column sizes for address fields
- Hide redundant country select
- Populate branch locations list
- Remove unused accommodation and amenities fields
- Move location details to reusable address component
- Add pet details form with name, breed, age, weight
- Require agreeing to safe drop policy before submitting
- Update confirmation checkbox text for clarity
- Adjust previous/next button labels for consistency
4, due to the extensive changes across multiple files, including the addition of new components, updates to existing components, removal of unused components, and the introduction of new JSON data files. The PR involves both frontend and backend changes, requiring a thorough review of code functionality, style, and potential side effects.
🧪 Relevant tests
No
🔍 Possible issues
Possible Bug: The removal of RequestForm.vue and FoodRequestForm.vue components without ensuring all their functionalities are covered by the new FoodDeliveryForm.vue component.
Performance Concern: The addition of multiple JSON files for dropdown options could impact the loading time if not properly handled or cached.
Code Duplication: Similar JSON structures for country and language options suggest a potential for code duplication or unoptimized data handling.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![joshua-keaton[bot]](https://avatars.githubusercontent.com/in/857594?s=60&v=4){kind=small}
User description
This pull request fixes issue #38 by making several changes to the RequestForm component. The changes include removing unused files, refactoring the component, adding missing pages, updating dependencies, and improving form layout and validation. These changes enhance the functionality and user experience of the request form.
Type
enhancement, documentation
Description
FoodDeliveryForm.vuecomponent with dark mode support.RequestForm.vueandFoodRequestForm.vuecomponents.FoodDeliveryFormStateinterface for the new food delivery form component.@vueform/plugin-mask.@vueform/plugin-maskdependency.Changes walkthrough
6 files
RequestForm.vue
Remove Unused RequestForm Componentapps/ui/components/RequestForm.vue
RequestForm.vuecomponent.FoodDeliveryForm.vue
Add Food Delivery Form Component with Dark Mode Supportapps/ui/components/requests/FoodDeliveryForm.vue
FoodDeliveryForm.vuecomponent for handling food deliveryrequests.
delivery form.
FoodRequestForm.vue
Remove Unused FoodRequestForm Componentapps/ui/components/requests/FoodRequestForm.vue
FoodRequestForm.vuecomponent.dashboard.vue
Update Dashboard Layout with New Icons and Settings Page Linkapps/ui/layouts/dashboard.vue
index.vue
Update Dashboard Index with New Request Form and Historyapps/ui/pages/dashboard/index.vue
request history.
settings.vue
Add New Settings Page for Portal Customizationapps/ui/pages/settings.vue
customization.
1 files
index.nuxt.test.ts
Add Test Cases for Dashboard Index Pageapps/ui/pages/dashboard/index.nuxt.test.ts
2 files
index.d.ts
Add FoodDeliveryFormState Interface for Food Delivery Formapps/ui/types/index.d.ts
FoodDeliveryFormStateinterface for the new food delivery formcomponent.
vueform-plugin-mask.d.ts
Add Type Declaration for Vueform Mask Pluginapps/ui/types/vueform-plugin-mask.d.ts
@vueform/plugin-mask.1 files
vueform.config.ts
Configure Vueform with Mask Pluginapps/ui/vueform.config.ts
2 files
package.json
Add Vueform Mask Plugin Dependencyapps/ui/package.json
@vueform/plugin-maskdependency.pnpm-lock.yaml
Update Lock File with New Dependenciesapps/ui/pnpm-lock.yaml
4 files
branch_locations.json
Add Branch Locations JSON Data for Food Delivery Formapps/ui/public/json/branch_locations.json
countries.json
Add Countries JSON Data for Food Delivery Formapps/ui/public/json/countries.json
divisions_level1.json
Add Divisions Level1 JSON Data for Food Delivery Formapps/ui/public/json/divisions_level1.json
languages.json
Add Languages JSON Data for Food Delivery Formapps/ui/public/json/languages.json