wss:// support #138
Open
wss:// support #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes Ankermgmt#131 Starting with the new firmware releases to anker make printers in the past few weeks, MQTT no longer connects. There is a field in the mqtt msg that expects 11 zeroes. these 11 bytes are no longer all zeroes. I switched the protocol to expect just bytes here since we did nothing with the zeroes to begin with this should be a backwards compatible change. Pasted below is a snippet from my terminal printing out the padding field. you'll see 2 bytes in the middle of the 11 that are no longer zeros. ``` [*] Padding: 0x0 0x0 0x0 0x3c 0x11 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0x95 0x15 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0xc6 0x20 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0x5c 0x1d 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0xa9 0x18 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0xfa 0xf 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0x99 0x21 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0xd6 0x15 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0x4c 0x9 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0x3d 0x13 0x0 0x0 0x0 0x0 0x0 0x0 [*] Padding: 0x0 0x0 0x0 0xe3 0xb 0x0 0x0 0x0 0x0 0x0 0x0 ``` Screenshot showing all green on the web ui after my change <img width="1036" alt="image" src="https://github.com/Ankermgmt/ankermake-m5-protocol/assets/22949655/9efce17f-a1e2-44cc-b2a7-1550c211a10c">
Added ability to use wss for ssl deployments (eg traefik/nginx proxy manager).
|
Can you provide screenshots as well as documentation on how you configure this for operation? |
The change doesn't have any configuration needs. It just allows for a reverse proxy to be able to use certificates/tls. The original code had hardcoded ws:// for the websocket url in the webui. This code automatically sets the protocol to wss for the websocket urls if https is being used. |
billyjbryant
approved these changes
Jan 15, 2024
|
Can you target the upcoming branch instead of master? |
|
I assume you mean "upcoming/v1.1". Done |
1.0.1 - Fix mqtt bug release
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to use wss for ssl deployments (eg traefik/nginx proxy manager).