-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to limit items to the hosts guild #15
base: main
Are you sure you want to change the base?
Conversation
- FailedGuild - FailedGuildRank and their translation to a chat message
- on pack check for G and R following G - Test on client and server side - add to default object
Open questions:
rest of questions on discord, I would say also, edge cases that might be in like 1% the case, but not sure if there always needs to be a 100% solution (as this 100% solution would either mess up with the UI or requires a lot of effort from either the person whos configuring that or development time as a big change would be needed for those minor cases) |
continuing from discord: I like how the guild checks seem to be reliable at any distance. I still think that "same guild" is a good enough way to store it. I would have liked to be able to lock items to one or more guilds by guild name, but I'm certain that feature would be rarely needed, and I can't see any way to do it reliably without fixing the UnitIsVisible issue. I'm also happy to report that the functions you chose will continue to work even when the player is offline! I might have insisted on falling back to guild scanning otherwise to make sure the checks are reliable. but as it stands, I wasn't able to find any cases where the functions failed. things that I would like to be implemented before merging:
you're welcome to make these changes yourself or discuss them and convince me some or all aren't necessary. or I'll get to it eventually, but there's no telling when that will be since my development on this addon has very slow for awhile now. |
Add possibility of limiting loot to be just accessible by players in the guild of the host.