Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to limit items to the hosts guild #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TheDevilofme
Copy link

Add possibility of limiting loot to be just accessible by players in the guild of the host.

  • New dropdown in loot edit window
  • new client and serverside Test if item can be reserved

- FailedGuild
- FailedGuildRank
and their translation to a chat message
- on pack check for G and R following G
- Test on client and server side
- add to default object
- add dropdown for guild rank
- add the option to add limit by guild rank on edit items
@TheDevilofme
Copy link
Author

Open questions:

  • what should happen if the host drops guild mid raid (my guess here would be, only option would be to remove the check or just take not care about this case as this is a minor case that might not happen that often, when you configure smth like that)
  • host changes to a different character that isn't in the guild but is still hosting - is the check not just in place when beggining the reserves (so might also be an edge case not worth investing time, as reserves are not constantly changed normally)

rest of questions on discord, I would say also, edge cases that might be in like 1% the case, but not sure if there always needs to be a 100% solution (as this 100% solution would either mess up with the UI or requires a lot of effort from either the person whos configuring that or development time as a big change would be needed for those minor cases)

@Anonomit
Copy link
Owner

continuing from discord: I like how the guild checks seem to be reliable at any distance. I still think that "same guild" is a good enough way to store it. I would have liked to be able to lock items to one or more guilds by guild name, but I'm certain that feature would be rarely needed, and I can't see any way to do it reliably without fixing the UnitIsVisible issue.

I'm also happy to report that the functions you chose will continue to work even when the player is offline! I might have insisted on falling back to guild scanning otherwise to make sure the checks are reliable. but as it stands, I wasn't able to find any cases where the functions failed.

things that I would like to be implemented before merging:

  • the guild restriction should exist for both reserves and rolls. it should be possible for a raid to restrict an item to "guild roll" without anyone being able to reserve it. to do this they'd set a guild restriction on the item and also mark it as hidden. I don't think rolls from non guild members should be ignored, but instead should have a red glow as is already implemented for a few other cases. that particular code is a mess and is repeated slightly differently in a few places, but I'd want it to highlight when a guild restricted item is rolled on by a player who does not meet the restriction.
  • the reserves window should show guild restricted items when reserves are locked, regardless of whether the player meets the restriction.
  • the UI shouldn't overlap in the loot list edit window. maybe combining the guild restriction into the "hidden" option by making that a dropdown? I'm not sure how that would look. worst case, the rows could be made taller. I think it wouldn't look very good and it would mean having to scroll more, but maybe in the end it would be better than trying to squish the options into the space that's currently available. I'm not too concerned about how pretty the UI is, especially on this window that's only seen by hosts. I still want it to not overlap though.
  • I think the host should still be able to modify the guild restrictions without being in a guild. the list would probably just say "guild rank 1" or something insteadof an actual rank. this way it would be possible to fully customize the loot restrictions on any unguilded character. to avoid (some) confusion when viewing the restrictions from a character in a different guild, perhaps the rank list could show the rank number as well? instead of showing "Guild Master" it would display "1. Guild Master" or some format like that. that might make it more clear to people why they're seeing an item restricted to "Executive Overlord" when they're in a different guild (with different guild ranks) even though they set it to "Guild Master".

you're welcome to make these changes yourself or discuss them and convince me some or all aren't necessary. or I'll get to it eventually, but there's no telling when that will be since my development on this addon has very slow for awhile now.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants