Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use % notation instead of .format in toast js & livereload js #588

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

comhar
Copy link
Contributor

@comhar comhar commented Nov 22, 2024


name: toast js + livereload js cleanup
about: use % notation instead of .format in toast js & livereload js
title: '[PR] '
labels: 'cleanup'
assignees: ''


Related Issue
This is a followup to PR 587

Proposed Changes
Use % notation instead of .format in toast js + livereload js

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cleanup

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

@comhar comhar added the cleanup minor code improvements that don't impact existing functionality label Nov 22, 2024
@comhar comhar requested a review from jph00 November 22, 2024 12:07
@comhar comhar mentioned this pull request Nov 22, 2024
9 tasks
@jph00
Copy link
Contributor

jph00 commented Nov 22, 2024

Thanks!

@jph00 jph00 merged commit 131b5a5 into main Nov 22, 2024
2 checks passed
@jph00 jph00 deleted the js-script-formatting-cleanup branch November 22, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup minor code improvements that don't impact existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants