Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdf extension to static routes #616

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add pdf extension to static routes #616

merged 2 commits into from
Jan 6, 2025

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented Dec 27, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Add pdf extension to static routes'
labels: 'enhancement'
assignees: ''


Related Issue

#502

Proposed Changes

For those of us who want to serve PDFs as a static file, this allows that type of behavior.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Copy link

gitnotebooks bot commented Dec 27, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/616

@jph00 jph00 merged commit 3a9797e into main Jan 6, 2025
2 checks passed
@jph00 jph00 deleted the add-pdf-2-reg_re_param branch January 6, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants