Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect web socket connection after server error #642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgwyer
Copy link
Contributor

@dgwyer dgwyer commented Jan 28, 2025


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.

Proposed Changes
When using live reload, after a server error (e.g. triggered by a typo in your app source code) the web socket does not automatically reconnect. This PR fixes that. When the server restarts from an error the WS is automatically reconnected.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

@dgwyer dgwyer changed the title Reconnect web socket connectin after server error Reconnect web socket connection after server error Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant