feat(area): move area command creation #2322
Open
+385
−306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/move-area-command-creation
MartinBelthle
requested changes
Jan 30, 2025
maugde
reviewed
Jan 30, 2025
MartinBelthle
requested changes
Jan 30, 2025
There was a problem hiding this comment.
I encountered a "bug" which was already present before your dev. When updating the color of an area inside the layer1, it also brings back its position to the layer 0 position. I don't think we should do that.
We should investigate and if we can change this, fix it and add a test inside the test_area.py file you introduced
…-creation # Conflicts: # antarest/study/storage/variantstudy/business/command_reverter.py
|
We can merge this. I will create a ticket adressing the bug that might comes from the front |
maugde
reviewed
Feb 6, 2025
| set: t.Optional[t.List[str]] = None | ||
|
|
||
|
|
||
| # review: is this class necessary? |
There was a problem hiding this comment.
I removed the comment because it is still used. Thanks for pointing out
maugde
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a command to move an area on the map. Replace multiple UpdateConfig commands