fix(commands): fix error on command notifications #2323
+139
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
131b44c to
a5bb352
Compare
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
6a0face to
8ea2595
Compare
smailio
reviewed
Feb 4, 2025
antarest/study/storage/variantstudy/variant_command_generator.py
Outdated
Show resolved
Hide resolved
smailio
reviewed
Feb 4, 2025
antarest/study/storage/variantstudy/variant_command_generator.py
Outdated
Show resolved
Hide resolved
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
d6f6678 to
488597f
Compare
MartinBelthle
requested changes
Feb 4, 2025
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
6eb3ae4 to
175e5ad
Compare
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
175e5ad to
1845678
Compare
MartinBelthle
requested changes
Feb 5, 2025
antarest/study/storage/variantstudy/variant_command_generator.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/variant_command_generator.py
Outdated
Show resolved
Hide resolved
…ng step, add comments,
…and_generator, change the call to notifier in _generate
… unnecessary lines and variables, check types
maugde
force-pushed
the
fix/2511-error-command-notifications
branch
from
baaebb8 to
6e3adef
Compare
sylvlecl
reviewed
Feb 6, 2025
| @@ -9,3 +9,6 @@ | |||
| # SPDX-License-Identifier: MPL-2.0 | |||
| # | |||
| # This file is part of the Antares project. | |||
| import typing as t | |||
|
|
|||
| CommandNotifier = t.Callable[[int, bool, str], None] | |||
sylvlecl
reviewed
Feb 6, 2025
| if notifier: | ||
| notifier(index - 1, output.status, output.message) | ||
| if notifier and cmd.command_id not in command_block_set: | ||
| notifier(command_block_dict[cmd.command_id], output.status, output.message) |
There was a problem hiding this comment.
@maugde @MartinBelthle :
Actually it's weird to notify only on the first command of a block.
In particular, we will notify with the status of this first command, but not for subsequent commands:
so for example if the first command succeeds and the second one fails, it will be invisible from the listener.
In the end I would propose to change the scope of this work:
I think the notification mechanism is actually not used (it just sends an event to the event bus, but this event type is never used for now. I cannot see a usage in the near future.
--> I propose to simply delete this notifier and the associated event type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ANT-2511