Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the upgrade from v8.8 to 9.2 of hydro power matrices [ANT-2742] #2625

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

guilpier-code
Copy link
Contributor

@guilpier-code guilpier-code commented Feb 7, 2025

Fixes problem described in issue ANT-2742

This fix is a quick fix : code could be cleaner.
Some refactoring could make code more readable when reading it again in a few months / years.
In particular, we could create an interface for reading and saving this data (hydro power) and create 2 classes implementing this interface and encapsulating each case (read/write daily or hourly)

…ding to value of parameter hydro-pmax

We save hourly power time series only if hydro-pmax == hourly
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. enums don't need to be passed by reference

enum Color
{
    Red, Blue
};
void printColor(Color c);

Also, formatting

@guilpier-code guilpier-code marked this pull request as draft February 7, 2025 12:18
@guilpier-code guilpier-code marked this pull request as ready for review February 7, 2025 12:55
@guilpier-code
Copy link
Contributor Author

LGTM. enums don't need to be passed by reference

enum Color
{
    Red, Blue
};
void printColor(Color c);

Also, formatting

Done

@flomnes flomnes changed the title Hydro : fix the upgrade from v8.8 to 9.2 of power matrices Hydro : fix the upgrade from v8.8 to 9.2 of power matrices [ANT-2742] Feb 10, 2025
@flomnes flomnes changed the title Hydro : fix the upgrade from v8.8 to 9.2 of power matrices [ANT-2742] Fix the upgrade from v8.8 to 9.2 of hydro power matrices [ANT-2742] Feb 10, 2025
@flomnes flomnes merged commit 6891f9e into develop Feb 10, 2025
10 checks passed
@flomnes flomnes deleted the fix/upgrade-hydro-from-v8.8-to-9.2 branch February 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants