Feature/ant 2636 parquet writesupport #27
Draft
+715
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 22, 2025 16:55
vargastat
commented
Jan 31, 2025
|
|
||
| public MatrixGroupConverter(GroupType schema, int rowCount) { | ||
| Objects.requireNonNull(schema); | ||
| this.rowCount = Objects.checkIndex(rowCount, 8761); |
There was a problem hiding this comment.
not sure if we need checkIndex method here to check rowCount? if rowCount is 8761 index of rows will be from 0 to 8760
vargastat
commented
Jan 31, 2025
| public static Matrix readMatrixFromTxt(Path filePath) throws IOException { | ||
| Objects.requireNonNull(filePath); | ||
|
|
||
| var lines = Files.readAllLines(filePath); |
There was a problem hiding this comment.
Maybe is better to use File.lines(filePath) which returns a stream to read large files
vargastat
commented
Jan 31, 2025
| var endDeserialization = System.nanoTime(); | ||
| var deserializationTime = (endDeserialization - startDeserialization) / 1_000_000_000.0; | ||
|
|
||
| System.out.println("Serialization time: " + serializationTime); |
There was a problem hiding this comment.
better to use Log.info than System.out.println
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.