fix: import BaseInterfaceModel from correct location #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Oct 25, 2024
|
Is this critical to release? |
No, and I am even thinking on exporting the base-model stuff from the root of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It is only incidental that this even works, all the basemodel stuff is defined in
ape.utils.basemodeland has been since its existence. Something inape.types.__init__is usingBaseInterfaceModelwhich is why it was working.It is not even listed in the
__all__https://github.com/ApeWorX/ape/blob/v0.8.17/src/ape/types/__init__.py#L573 so I am surprised you don't at least get static import warnings.How I did it
Import from the correct spot.
How to verify it
Checklist