Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add accounts python file #3

Closed
wants to merge 106 commits into from
Closed

feat: add accounts python file #3

wants to merge 106 commits into from

Conversation

johnson2427
Copy link
Collaborator

What I did

Adding aws kms interface capability

fixes: #

How I did it

boto3 API calls

How to verify it

TBD

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

johnson2427 and others added 3 commits January 6, 2022 13:49
@johnson2427
Initial commit
d950fff
@johnson2427
Initial Commit with README to explain AWS Setup
5708f95
@johnson2427
Feat:
d61fb48 
Added functionality for creating Eth Node for AWS in scratch folder.
Also grabbed aws-kms-ethereum-accounts code and placed it in scratch folder.
Have to add to Ape structured cli architecture.
fubuloubu
fubuloubu reviewed Apr 12, 2024
View reviewed changes
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/utils.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
ape_aws_kms/utils.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
@johnson2427
Copy link
Collaborator Author

The message is DER encoded. From the looks of it, the first value of the signature is a standard (48, sometimes other values), and the second tells you how many characters define the signature. This value can change.

AWS uses asn1 tools to compile the information given to the signer, then decodes with that.

fubuloubu
fubuloubu reviewed Apr 15, 2024
View reviewed changes
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 22, 2024
View reviewed changes
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 22, 2024
View reviewed changes
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
ape_aws_kms/accounts.py Outdated Show resolved Hide resolved
johnson2427
johnson2427 commented Apr 25, 2024
View reviewed changes
ape_aws_kms/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 27, 2024
View reviewed changes
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/providers.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 29, 2024
View reviewed changes
ape_aws/utils.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 30, 2024
View reviewed changes
ape_aws/utils.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed Apr 30, 2024
View reviewed changes
ape_aws/admin/_cli.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/client.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/client.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 1, 2024
View reviewed changes
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 2, 2024
View reviewed changes
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

Actually kinda of a neat find, you can use this to "type check" your dicts and kwargs (and some values) with boto usage: https://pypi.org/project/boto3-stubs/

fubuloubu
fubuloubu reviewed May 2, 2024
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting very close!

ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
ape_aws/client.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

Be nice to add a few tests for signing, then add py 3.10 and 3.11 (3.12 if it's easy)

You can drop 3.8 if you want, Ape v0.8 is gonna get rid of it and it doesn't matter for use with Silverback anyways (3.9 for that matter too)

fubuloubu
fubuloubu reviewed May 4, 2024
View reviewed changes
ape_aws/utils.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 4, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the transaction tests

setup.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
johnson2427
johnson2427 commented May 6, 2024
View reviewed changes
tests/test_accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 6, 2024
View reviewed changes
tests/test_accounts.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu reviewed May 7, 2024
View reviewed changes
tests/test_accounts.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/kms/_cli.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
ape_aws/accounts.py Outdated Show resolved Hide resolved
fubuloubu and others added 26 commits May 8, 2024 14:01
@fubuloubu @johnson2427
docs: add TODO note
df228cc
@fubuloubu @johnson2427
refactor: add number of days
71b47da
@fubuloubu @johnson2427
docs: add TODO for sign/verify w/ KMS acct
23146d3
@fubuloubu @johnson2427
fix: run lint 3.10+
265f64b
@fubuloubu @johnson2427
fix: commitlint 3.10
9f4df6a
@fubuloubu @johnson2427
fix: release worflow use 3.10
d82fdf8
@fubuloubu @johnson2427
fix: pr title check use 3.10
38620b8
@fubuloubu @johnson2427
fix: f-string error
e67e315
@fubuloubu @johnson2427
chore: fix mypy stub error
2d726d3
@fubuloubu @johnson2427
chore: fix mypy stub error
cf72f99
@johnson2427
refactor: remove scratch folder
b4be969
@johnson2427
refactor: cli files
ca2b03e
@johnson2427
fix: testing
973489a
@johnson2427
fix: update versions
9243bb3
@johnson2427
fix: bad type hint
cd999d9
@johnson2427
refactor: clean sign_transaction
5760775
@johnson2427
fix: type hinting
3c472ca
@johnson2427
refactor: reorder imports
db19853
@johnson2427
fix: expected type of _sign_raw_hash
7b28b72
@johnson2427
feat: adding aws cli to github workflow
5e340f8
@johnson2427
feat: add aws access keys
9d232f6
@johnson2427
feat: add default region and output for tests
d6ac024
@johnson2427
feat: show default profile github actions
a6a5891
@johnson2427
fix: github actions
0e74ad6
@johnson2427
fix: run command for aws cli
731c615
@johnson2427
feat: use aws-actions
f7d54dd
@johnson2427 johnson2427 closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnson2427 @fubuloubu