-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update comments in Multisend example #33
base: main
Are you sure you want to change the base?
Conversation
As per request ApeWorX#32 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to find a way to refactor the plugin so that this is no longer what you need to do to get a partially signed transaction into the Safe API
cc @antazoey what do you think?
I thought the issue was on the core side. In any case, documenting the way it works today is not a bad thing. |
Issue can be improved with some core updates, but also the assumption if you are executing a transaction directly is that you want to execute it right now, so there should be an easier way to do the second workflow where you don't want to execute it right now that doesn't involve raising an error even though it is actually successfully performing that task maybe something like from ape_safe import multisend
from ape import accounts
# load the safe
safe = accounts.load("my-safe")
ms = multisend.MultiSend()
ms.add(contractA.myMethod1, *call_args)
ms.add(contractB.myMethod2, *call_args)
... # Add as many calls as desired to execute
ms.add(contractC.myMethod3, *call_args)
safetx = safe.propose(ms.as_transaction()) |
there is a propose cli method you could try |
can that be "upstreamed" into the SafeAccount? |
p.s. added this here: 9aa25ab |
Probably! |
What I did
Updated the comments on multisend showing users how to stage transaction without getting caught with the error in case not enough signers are available on local.
fixes: #
As per request #32 (comment)
How I did it
NA
How to verify it
NA
Checklist