fix: include URI in provider.network_choice

[antazoey]

What I did

fixes: ApeWorX/silverback#179

How I did it

When a URI is configured or passed in for a connection, use that in provider.network_choice

How to verify it

silverback uses the configured URI everywhere now.

I made sure:

• ape-foundry tests still pass
• ape-alchemy tests still pass
• silverback tests pass (though you may want to add a new one for the reported issue)

Checklist

• All changes are completed
• New test cases have been added
• Documentation has been updated

[antazoey]

this now happens at the provider-connection level, so the config value is None when not actually configured (and doesn't get set to random RPC). So the behavior is the same, just happens at a different spot, it helps us know when a value was specifically configured by the user (and not injected here)

[stas]

I'm afraid this release (or more likely #2464) broke the custom networks support:
https://github.com/velodrome-finance/sugar/actions/runs/12713130520/job/35440324276

Using this config:

networks:
  custom:
    - name: mainnet
      ecosystem: mode
      chain_id: 34443

node:
  mode:
    mainnet:
      uri: https://mode.drpc.org

Running:

docker run --rm --env-file=deployments/mode.env -v $(pwd):/app -w /app -t velodrome/sugar sh -c 'python -m black . && ape test --network mode --disable-isolation'

Ape seems to be connecting to Sepolia

ape.exceptions.NetworkMismatchError: Provider connected to chain ID '1337', which does not match network chain ID '34443'. Are you connected to 'mainnet'?

[antazoey]

I'm afraid this release (or more likely #2464) broke the custom networks support:

#2464 has not been released yet. Are you using the main branch or 0.8.24?
Either way, I am looking into it.

[antazoey]

@stas OK I believe I have figured it out: #2466
Can you let me know if this works for you?

[stas]

@stas OK I believe I have figured it out: #2466
Can you let me know if this works for you?

Thanks so much! Will switch back to the latest for our CI to confirm.