Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libpipewire-0.3.so.0 to excludelist #556

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Samueru-sama
Copy link
Contributor

@probonopd
Copy link
Member

See my answer there.

@TheAssassin
Copy link
Member

Fine by me, it's the same as with libjack.

@TheAssassin TheAssassin merged commit 6f7ad0a into AppImageCommunity:master Aug 27, 2024
1 check passed
@probonopd
Copy link
Member

Waiting for the first person to complain that an application doesn't run because libpipewire is not on the system. (Could well be me.)

Let's see...

@Samueru-sama
Copy link
Contributor Author

I was able to bundle pipewire successfully here.

I tested the AppImage on a voidlinux musl vm and it worked without issues. All that has to be done is bundle the spa-0.2 and pipewire-0.3 lib dirs and set the env variables SPA_PLUGIN_DIR PIPEWIRE_MODULE_DIR to those.

With that said this was tested on an AppImage that bundles everything instead of the ones that rely on the host glibc where this exclude list is used, and also the fact that the env variables need to be set means that it is better for this lib to still be kept on the list, since if the variables are not set the app crashes lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants