Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of arm64 (#563) #564

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

sbernhard
Copy link
Contributor

No description provided.

@probonopd
Copy link
Member

Thank you very much @sbernhard. What did you test it with?

@sbernhard
Copy link
Contributor Author

I have build the pkg2appimage on a arm64 system. Then I tried to build a app from the default recipes folder. Unfortunately, I can not remember. I want to continue with this next week.
Luckily, I saw this: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
Therefore I extended this PR to build pkg2appimage directly on github for arm64 and x86_64.
I guess, if you would approve this PR, then the github actions would start and we can easily proceed. I would the continue with more testing of course.

@probonopd
Copy link
Member

Indeed, that's great news.
Strangely it doesn't seem to be working yet. Maybe it's already overloaded?

@sbernhard sbernhard force-pushed the arm64_support branch 2 times, most recently from 771bcad to a6e7e1d Compare January 18, 2025 09:46
@sbernhard
Copy link
Contributor Author

ah, it was just a issue how to construct to build on arm vs amd64. now it works. Thanks for the approval.

@sbernhard
Copy link
Contributor Author

Would it be somehow possible to add a "test" step directly after the build? like, use the created pkg2appimage to create a simple recipe and then run it?

@probonopd
Copy link
Member

probonopd commented Jan 18, 2025

Yes, I think that would be a good idea. Use the generated AppImage to make another AppImage using a simple recipe.

We should do it in dogfeeding.sh which is based on the idea of "eating our own dogfood".

@probonopd
Copy link
Member

Hm. Seems like using the short git hash as the version is not working yet (was broken already before this PR). Can you spot what is going wrong?

@sbernhard
Copy link
Contributor Author

Hm. Seems like using the short git hash as the version is not working yet (was broken already before this PR). Can you spot what is going wrong?

Is it about setting the TRAVIS_BUILD_NUMBER?
See my last commit.

@sbernhard
Copy link
Contributor Author

Yes, I think that would be a good idea. Use the generated AppImage to make another AppImage using a simple recipe.

We should do it in dogfeeding.sh which is based on the idea of "eating our own dogfood".

I added it as a seperate test in the github action. Addtionally, I added neovim as a very simple AppImage which can be easily tested.

@sbernhard sbernhard force-pushed the arm64_support branch 2 times, most recently from 992af33 to c0ad11f Compare January 18, 2025 15:34
@probonopd
Copy link
Member

Travis is long history. We should remove all mentions of TRAVIS_BUILD_NUMBER and replace it by VERSION.

@sbernhard
Copy link
Contributor Author

Just saw, that you throw away the travis stuff @probonopd. Therefore, I have removed the VERSION / git commits from this PR - I hope this was correct? Thought this was the changes you did with the other PR you have already merged today.

I have rebased this PR and adapted it again. I guess, the test shoud now run - or, at least one step further :)

@probonopd
Copy link
Member

Looks like that neovim is too new?

@sbernhard
Copy link
Contributor Author

Hmm, lets try to use ubuntu focal instead of noble.

@sbernhard
Copy link
Contributor Author

I hope it works now @probonopd

@sbernhard
Copy link
Contributor Author

can you start the github pipeline again, please @probonopd

@probonopd
Copy link
Member

What is lua being used for?

@sbernhard
Copy link
Contributor Author

What is lua being used for?

Something in neovim requires lua-luv

@probonopd
Copy link
Member

probonopd commented Jan 25, 2025

Let's remove neovim then. The debian packager "hello" should do?

@sbernhard
Copy link
Contributor Author

@probonopd yes, shell script would also somehow work - but this would be a new story somehow and I thought, it's easier to have quick test of a somehow up-to-date package.

I changed the neovim recipe again. hope that it works now. actually, I would be much easier, if this PR approval to run the pipeline would not be necessary. (sorry for this hassle)

@probonopd
Copy link
Member

Can't we use

https://packages.debian.org/unstable/hello

instead of neovim? I don't feel comfortable drawing in new dependencies.

@sbernhard
Copy link
Contributor Author

@probonopd Yes, I have changed this.

@probonopd probonopd merged commit bd9684f into AppImageCommunity:master Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants