-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of arm64 (#563) #564
Conversation
Thank you very much @sbernhard. What did you test it with? |
I have build the pkg2appimage on a arm64 system. Then I tried to build a app from the default recipes folder. Unfortunately, I can not remember. I want to continue with this next week. |
Indeed, that's great news. |
771bcad
to
a6e7e1d
Compare
ah, it was just a issue how to construct to build on arm vs amd64. now it works. Thanks for the approval. |
Would it be somehow possible to add a "test" step directly after the build? like, use the created pkg2appimage to create a simple recipe and then run it? |
Yes, I think that would be a good idea. Use the generated AppImage to make another AppImage using a simple recipe. We should do it in |
Hm. Seems like using the short git hash as the version is not working yet (was broken already before this PR). Can you spot what is going wrong? |
c902d69
to
6e355c0
Compare
Is it about setting the TRAVIS_BUILD_NUMBER? |
I added it as a seperate test in the github action. Addtionally, I added neovim as a very simple AppImage which can be easily tested. |
992af33
to
c0ad11f
Compare
Travis is long history. We should remove all mentions of |
c0ad11f
to
5923f96
Compare
5923f96
to
8ed643f
Compare
Just saw, that you throw away the travis stuff @probonopd. Therefore, I have removed the VERSION / git commits from this PR - I hope this was correct? Thought this was the changes you did with the other PR you have already merged today. I have rebased this PR and adapted it again. I guess, the test shoud now run - or, at least one step further :) |
Looks like that neovim is too new? |
8ed643f
to
8fddf80
Compare
Hmm, lets try to use ubuntu focal instead of noble. |
8fddf80
to
1575102
Compare
I hope it works now @probonopd |
can you start the github pipeline again, please @probonopd |
What is lua being used for? |
Something in neovim requires lua-luv |
Let's remove neovim then. The debian packager "hello" should do? |
ad99826
to
203cb83
Compare
@probonopd yes, shell script would also somehow work - but this would be a new story somehow and I thought, it's easier to have quick test of a somehow up-to-date package. I changed the neovim recipe again. hope that it works now. actually, I would be much easier, if this PR approval to run the pipeline would not be necessary. (sorry for this hassle) |
203cb83
to
c0121d5
Compare
Can't we use https://packages.debian.org/unstable/hello instead of neovim? I don't feel comfortable drawing in new dependencies. |
1f3d21a
to
90b048a
Compare
@probonopd Yes, I have changed this. |
No description provided.