Merge pull request #43 from Appsilon/minor-description-fix

chore: Correct Title in DESCRIPTION.
Appsilon · Nov 22, 2023 · 3de5bce · 3de5bce
2 parents f1c5229 + 7b6c118
commit 3de5bce
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,4 +1,4 @@
-name: CI
+name: End-to-end tests
 on: push
 permissions:
   contents: read
@@ -33,12 +33,6 @@ jobs:
         run: yarn install
         working-directory: e2e_tests
 
-      - name: R CMD check
-        if: always()
-        uses: r-lib/actions/check-r-package@v2
-        with:
-          error-on: '"note"'
-
       - name: Run Cypress
         if: always()
         uses: cypress-io/github-action@v5

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Type: Package
 Package: reactable.extras
-Title: Extra Features for 'Reactable' Package
+Title: Extra Features for 'reactable' Package
 Version: 0.2.0
 Authors@R:
   c(

diff --git a/tests/testthat/_snaps/reactable-server.md b/tests/testthat/_snaps/reactable-server.md
@@ -51,5 +51,5 @@
           <span id="test-page_controls-page_text" class="shiny-text-output"></span>
         </div>
       </div>
-      <div class="reactable html-widget html-widget-output shiny-report-size html-fill-item-overflow-hidden html-fill-item" data-reactable-output="test-reactable" id="test-reactable" style="width:auto;height:auto;"></div>
+      <div class="reactable html-widget html-widget-output shiny-report-size html-fill-item" data-reactable-output="test-reactable" id="test-reactable" style="width:auto;height:auto;"></div>
 
diff --git a/tests/testthat/test-reactable-server.R b/tests/testthat/test-reactable-server.R
@@ -189,6 +189,7 @@ test_that("return_reactable_page should return a reactive page value", {
 })
 
 test_that("reactable_extras_ui should return a widget of reactableOutput", {
+  skip_on_os(c("windows", "mac"))
   expect_error(reactable_extras_ui(1))
   expect_error(reactable_extras_ui(c("test1", "test2")))
   expect_snapshot(reactable_extras_ui("test"))