Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/deprecate serverside module #67

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vituri
Copy link

@vituri vituri commented Feb 10, 2025

This PR just updates the docs pointing to the new reactable version, where there is a native server-side processing option for a reactable. This will let us arquive/mark-as-solved any issues related to this module.

Description

Updated the server-side processing vignette with a warning
image

Added a

.Deprecated(
    new = "reactable::reactable",
    msg = "`reactable::reactable` now has a `server = TRUE` argument. Please use 'reactable' directly instead of this module."
  )

in reactable_extras_ui and changed its description to #' [Deprecated] Create reactable UI with server-side processing.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.00%. Comparing base (8dc8efc) to head (492adfa).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
R/reactable-server.R 96.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.97%   98.00%   +0.03%     
==========================================
  Files           4        4              
  Lines         247      251       +4     
==========================================
+ Hits          242      246       +4     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants