Fix function dwim-map, add missing dependency, fix whitespace
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix function `dwim-map` in chapter 6. It left the first sequence out from the mapping. Add also new unit test for this function. It detects the issue and prevents regression. * Fix method `generic-elt`, specialized for vectors, from chapter 7. It calculated the index wrong for negative keys. Add also new unit test for this method. It detects the issue and prevents regression. * Add missing dependency to the system definition. It made the system loading to fail on `ch14-compression.lisp` that uses flexi-streams. * Remove one unnecessary space from end of line.
octaspire
force-pushed
the
fix-dwim-map-and-dependency
branch
from
e9e0089 to
66e8380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix function
dwim-mapin chapter 6. It left the firstsequence out from the mapping. Add also new unit test
for this function. It detects the issue and prevents
regression.
Add missing dependency to the system definition. It made
the system loading to fail on
ch14-compression.lispthat uses flexi-streams.
Remove one unnecessary space from end of line.