feat: mid election rotation #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
commented
Feb 7, 2025
Comment on lines
427
to
431
| // this serves 2 purposes: | ||
| // 1. it prevents "chained" rotations | ||
| // 2. it allow one to check rotatingTo[x] to see if x can be a rotation target | ||
| _checkNotRotatingSrcOrTarget(newAddress); | ||
| rotatingTo[newAddress] = newAddress; |
There was a problem hiding this comment.
Tbh we might as well drop these check and relies on the psudo try-catch in replaceCohort entirely; say if somehow all elected member decided to set rotateForFutureMember to the same address, it simply would became a no-op. What's important is you cannot dos other user who actually want to rotate, but the signature check should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.