Make fastapi a regular dependency #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
EricGustin
commented
Feb 6, 2025
Comment on lines
-4
to
-19
| { | ||
| "name": "Debug examples/fastapi", | ||
| "type": "python", | ||
| "request": "launch", | ||
| "module": "uvicorn", | ||
| "args": [ | ||
| "main:app", | ||
| "--app-dir", | ||
| "${workspaceFolder}/examples/fastapi/arcade_example_fastapi", | ||
| "--port", | ||
| "8002" | ||
| ], | ||
| "jinja": true, | ||
| "justMyCode": true, | ||
| "cwd": "${workspaceFolder}/examples/fastapi/arcade_example_fastapi" | ||
| }, |
There was a problem hiding this comment.
cleanup. The fastapi example was removed a while ago.
EricGustin
commented
Feb 6, 2025
| { | ||
| "name": "Debug `arcade workerup --no-auth`", | ||
| "type": "python", | ||
| "type": "debugpy", |
There was a problem hiding this comment.
type: python is being deprecated in favor of type: debugpy
See https://devblogs.microsoft.com/python/python-in-visual-studio-code-february-2024-release/
EricGustin
commented
Feb 6, 2025
| @@ -29,8 +13,8 @@ | |||
| "cwd": "${workspaceFolder}" | |||
| }, | |||
| { | |||
| "name": "Debug `arcade chat -s -d -h localhost`", | |||
There was a problem hiding this comment.
cleanup: not actually streaming
EricGustin
commented
Feb 7, 2025
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "arcade-ai" | |||
| version = "1.0.1" | |||
| version = "1.1.0" | |||
There was a problem hiding this comment.
Since most people installed as pip install 'arcade-ai[fastapi]' I think it might be okay to only make this a minor release.
nbarbettini
approved these changes
Feb 7, 2025
| @@ -214,7 +214,7 @@ def evaluate(self, expected: str, actual: str) -> dict[str, float | bool]: | |||
| from sklearn.metrics.pairwise import cosine_similarity | |||
| except ImportError: | |||
| raise ImportError( | |||
| "Use `pip install arcade[evals]` to install the required dependencies for similarity metrics." | |||
| "Use `pip install 'arcade-ai[evals]'` to install the required dependencies for similarity metrics." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Changes
pip install 'arcade-ai[fastapi]'topip install arcade-ai.In other words, FastAPI is now a required dependecy of arcade-ai.
Additionally, I snuck in some minor cleanup changes.