Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search all plugins sidebar #962

Closed

Conversation

jean-emmanuel
Copy link
Contributor

@jean-emmanuel jean-emmanuel commented Jan 14, 2025

Following up PR #874 !

@jean-emmanuel jean-emmanuel force-pushed the search_all_plugins_sidebar branch from 05cdd88 to cc80458 Compare January 14, 2025 13:00
@x42
Copy link
Member

x42 commented Jan 18, 2025

I can already see user searching for "wav" and Ardour grinds to a halt listing 1000+ waves plugins :)
so be it rebased and merged as 9.0-pre0-728 a8f6fcc
Thanks you!

@x42 x42 closed this Jan 18, 2025
@jean-emmanuel
Copy link
Contributor Author

jean-emmanuel commented Jan 18, 2025

Hahaha maybe the results should only be displayed when a certain ceiling is reached with a hint otherwise such as "Too many matches, type more characters" ?

@jean-emmanuel
Copy link
Contributor Author

jean-emmanuel commented Jan 18, 2025

It occurred to me we might as well show a limited subset of results (20, 50?) regardless of how many chars are typed. I did a quick test here and it felt a little smoother to use, however I'm not sure about how/if to hint for the fact that some results are not shown: adding an ellipsis kind-of row looked fine but I didn't manage to make it un-draggable. Maybe I'm just overthinking this, what do you think ?

@x42
Copy link
Member

x42 commented Jan 18, 2025

We already have the same problem in the plugin selector's search.. so maybe just leave it as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants