Ardupilot 13082021 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address OSS Issue google#2463 google#2463 PiperOrigin-RevId: 333289989
Revision of recent DoubleNearPredFormat change to support more toolchains. isnan() is a macro in C99, and std::isnan() is a function in C++11. The previous change used `isnan` directly, and broke some tests in open source. This CL changes it to follow the practice in gmock-matchers.h, and spell uses of isnan as (std::isnan)(f) . The parens around `std::isnan` prevent it from being recognized as a macro in the preprocessor. PiperOrigin-RevId: 333374377
Please note that changing the default value for a type can make [you]* test..... Here "you" word doesn't make sense.. rather "your" seems to make it understandable.
Fix typo PiperOrigin-RevId: 333745750
PiperOrigin-RevId: 334384310
…be_unintialized PiperOrigin-RevId: 334391149
Update comment to suggest using SetUpTestSuite and TearDownTestSuite. PiperOrigin-RevId: 334430329
Fix undefined pointer comparison PiperOrigin-RevId: 334436975
Update faq.md on underscore to mention `DISABLED_` prefix. PiperOrigin-RevId: 334507963
…k from A1, A2, ... to TArg1, TArg2,... to avoid clash with legacy header files
PiperOrigin-RevId: 335653055
PiperOrigin-RevId: 336087297
Make the code Python3 compliant. PiperOrigin-RevId: 336144198
Improve lookup of operator<< for user types
Without this fix, trying to use this class with googletest
struct Foo {};
template <typename OutputStream>
OutputStream& operator<<(OutputStream& os, const Foo&) {
os << "TemplatedStreamableInFoo";
return os;
}
results in an ambiguity error between the class' operator<< and the
operator<< in gtest-printers.h removed in this CL.
This fix also enables implicit conversions to happen, so that e.g.
we will find the base class operator<< if a subclass has no
operator<< of its own.
PiperOrigin-RevId: 336261221
Add helper methos to internal FlatTuple. Refactor constructors. PiperOrigin-RevId: 336306681
Suggest using generic lambdas for composing macros.
Long chains of macros hurt legibility; generic lambdas are an easy way to abbreviate them, but are not an obvious solution to casual users.
Compare:
EXPECT_THAT(f(), ElementsAre(
Property(&MyClass::foo, Property(&OtherClass::bar, Contains("x"))),
Property(&MyClass::foo, Property(&OtherClass::bar, Contains("y"))));
to:
EXPECT_THAT(f(), ElementsAre(HasFooBar("x"), HasFooBar("y")));
PiperOrigin-RevId: 336870137
Use absl::StrCat in MATCHER_P example for consistency with https://abseil.io/tips/3 PiperOrigin-RevId: 336878481
PiperOrigin-RevId: 336881266
Fixes AppVeyor by upgrading to Bazel 3.6.0 PiperOrigin-RevId: 336887434
Fix -Wmismatched-tags error with struct tuple_size vs class tuple_size PiperOrigin-RevId: 336930166
Prefer using over typedef. PiperOrigin-RevId: 337080404
Disable -Wmismatched-tags warning for struct/class tuple_size PiperOrigin-RevId: 337087493
Removing a semicolon that triggers a lint error in sample code. PiperOrigin-RevId: 337095451
Stop using master.zip to make the build reproducible PiperOrigin-RevId: 337102716
Disable warnings on code that intentionally tests a suboptimal syntax PiperOrigin-RevId: 337138442
Add ::testing::FieldsAre matcher for objects that support get<> and structured bindings. PiperOrigin-RevId: 337165285
…plate-args-AX-to-TArgX PiperOrigin-RevId: 337217118
Add a note documenting that death test macros accept arbitrary gmock matchers against child-process stderr, not just regexes. PiperOrigin-RevId: 372365998
Fix links in Matchers Reference PiperOrigin-RevId: 372436732
Clean up heading levels and mention `::testing` namespace in Matchers Reference PiperOrigin-RevId: 373242122
Fix code in googletest parameterized name example. PiperOrigin-RevId: 373262838
Support templating MockFunction over function objects besides std::function. PiperOrigin-RevId: 373586967
Docs: Clarify that expectations must be set before mocks are exercised PiperOrigin-RevId: 373644072
Fix a comment in a code snippet. PiperOrigin-RevId: 374504337
Remove inapplicable example PiperOrigin-RevId: 374762004
Add missing link PiperOrigin-RevId: 374774097
Remove the dependency on Objective C++ in iOS builds. 252ce9c introduced the use of NSTemporaryDirectory() on iOS, which requires Core Foundation, and Objective C++. This CL replaces NSTemporaryDirectory() with an equivalent solution (according to Apple's documentation at [1]) available to C/C++ code. Avoiding Objective C++ and Core Foundation makes it easier to integrate googletest in projects that can't use the supplied Bazel build files. [1] https://developer.apple.com/library/archive/documentation/Security/Conceptual/SecureCodingGuide/Articles/RaceConditions.html#//apple_ref/doc/uid/TP40002585-SW10 PiperOrigin-RevId: 375474990
Add Google Analytics & footer PiperOrigin-RevId: 375539689
Updates Linux docker image to use Bazel 4.1.0 and GCC 11.1 Updates Bazel dependencies Removes the last usage of the deprecated and removed Python2 PiperOrigin-RevId: 375759184
Create Assertions Reference PiperOrigin-RevId: 375824718
Fix broken link PiperOrigin-RevId: 375995669
Create new Mocking Reference PiperOrigin-RevId: 376951575
Create new Testing API reference PiperOrigin-RevId: 376969148
…tTo as DLL exports This was causing the following linker error on Microsoft Visual C++ when compiling as a DLL: ``` googletest-printers-test.cc.obj : error LNK2019: unresolved external symbol "void __cdecl testing::internal::PrintTo(char16_t const *,class std::basic_ostream<char,struct std::char_traits<char> > *)" (?PrintTo@internal@testing@@YAXPEB_SPEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@z) referenced in function "public: static void __cdecl testing::internal::UniversalPrinter<char16_t const *>::Print(char16_t const * const &,class std::basic_ostream<char,struct std::char_traits<char> > *)" (?Print@?$UniversalPrinter@PEB_S@internal@testing@@SAXAEBQEB_SPEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@z) googletest-printers-test.cc.obj : error LNK2019: unresolved external symbol "void __cdecl testing::internal::PrintTo(char32_t const *,class std::basic_ostream<char,struct std::char_traits<char> > *)" (?PrintTo@internal@testing@@YAXPEB_UPEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@z) referenced in function "public: static void __cdecl testing::internal::UniversalPrinter<char32_t const *>::Print(char32_t const * const &,class std::basic_ostream<char,struct std::char_traits<char> > *)" (?Print@?$UniversalPrinter@PEB_U@internal@testing@@SAXAEBQEB_UPEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@z) ```
This was causing the following linker error on Microsoft Visual C++ when compiling as a DLL: ``` googletest-param-test-test.cc.obj : error LNK2019: unresolved external symbol "public: __cdecl testing::internal::MarkAsIgnored::MarkAsIgnored(char const *)" (??0MarkAsIgnored@internal@testing@@qeaa@PEBD@Z) referenced in function "void __cdecl works_here::`dynamic initializer for 'gtest_allow_ignore_NotInstantiatedTest''(void)" (??__Egtest_allow_ignore_NotInstantiatedTest@works_here@@yaxxz) ```
PiperOrigin-RevId: 377289133
Fix MSVC warning C4275: non dll-interface class 'testing::MatcherDescriberInterface' used as base for dll-interface class 'testing::internal::MatcherBase<std::string>' Fixes google#3415 PiperOrigin-RevId: 377352684
…k-failure PiperOrigin-RevId: 377367006
Add CNAME file for custom domain PiperOrigin-RevId: 377604116
Update broken link PiperOrigin-RevId: 378272186
Add CNAME file for custom domain PiperOrigin-RevId: 378384525
cleanup: fix spurious MSAN warnings with Clang 12 PiperOrigin-RevId: 378430614
Delete Travis config file PiperOrigin-RevId: 378483262
Add feature request issue template PiperOrigin-RevId: 378552571
Internal change PiperOrigin-RevId: 378672633
Release GoogleTest 1.11.0 PiperOrigin-RevId: 378861756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update gtest to latest release to solve compilation issue with GCC11