Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/fix(starter-game-template) update to use latest version of cardinal #15

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

pyrofolium
Copy link
Contributor

@pyrofolium pyrofolium commented Oct 25, 2023

Lots of files here. Don't worry most of those changes look straight forward and are related to camelCase. You'll skim through those pretty quick.

Lots of bugs and changes needed.

Many updates to the new camel case format.
Changes to use new cardinal api.
Some changes in another PR to fix various bugs.

…anges and lots of bug fixes.

May be more issues but tests currently all pass.
@pyrofolium pyrofolium requested a review from a team October 25, 2023 21:36
nakama/persona_tag_storage.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cardinal/game/archetypes.go Show resolved Hide resolved
nakama/cardinal.go Outdated Show resolved Hide resolved
cardinal/game/archetypes.go Show resolved Hide resolved
cardinal/system/system_attack.go Outdated Show resolved Hide resolved
Copy link
Contributor

@namrapatel namrapatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus Tyler's requested changes, agree with those:

@pyrofolium pyrofolium merged commit f5c2088 into main Oct 26, 2023
@smsunarto smsunarto deleted the brian/world-429/starter branch March 19, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants