Zeroisation #67
Draft
Zeroisation #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses deterministic buffers. Was causing undesirable fluctuation in keypair and encapsulation benches Fix: lint Rename: redundant function postfixes
This uses Rustcrypto's fixslice AES256 implementation in big-endian 32bit counter mode. Better side-channel resistance, especially on embedded devices. Recommend benchmarking before switching to measure any tradeoffs . Ref: https://eprint.iacr.org/2020/1123.pdf
…ware/kyber into rustcrypto-aes256ctr
This is due to the AES dependency used in 90s-fixslice
Add: 90s-fixslice tests
Fix: spelling
Basic implementation, doesn't account for move on return behaviour Can still leak on certain architectures due to how they manage RVO Compliers can also change the semantics of copy elision Zeroes out on x86_64 with GCC Needs `Pin` and/or `Box` version to ensure correctness across platforms Zeroises intermediate/transient secrets and coins * Modify: secret key visibility * Add: `expose_secret()`, make secret usage explicit * Modify: Keypair Debug impl to elide secret key * Add: impl Hash for Keypair, omits secret key * Add impl Eq/PartialEq for Keypair, omits secret key, non-constant time * Add: `zeroize!()` macro for code brevity Removes repeated `#[cfg(feature="zeroize")]` lines
Now imported from pqc_core
|
Due to a squash and merge policy never playing well with github this has a lot of already mainlined code. The meaningful changes are in:
macro_rules! zero {
($target: ident) => {
#[cfg(feature = "zeroize")]
$target.zeroize();
};
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfinished baseline for full zeroisation of secrets. Transient data like the secretkey polynomials are zeroed.
For now it just does the internals and requires Pin to ensure the same behaviour regardless of the copy on return semantics of platforms/compilers.