Port passthrough #135
Open
Port passthrough #135
+182
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatAmISupposedToPutHere
force-pushed
the
port-publish
branch
3 times, most recently
from
e7a316e to
f50e0a3
Compare
WhatAmISupposedToPutHere
force-pushed
the
port-publish
branch
from
f50e0a3 to
0d68251
Compare
WhatAmISupposedToPutHere
requested review from
slp,
teohhanhui,
alyssarosenzweig and
asahilina
as code owners
|
Does this subsume #134? |
|
Not really. Those are prs for different features, that just happen to be dependent on each other. |
WhatAmISupposedToPutHere
force-pushed
the
port-publish
branch
from
0d68251 to
7d4bbbf
Compare
This will allow implementing other network topologies. Signed-off-by: Sasha Finkelstein <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
WhatAmISupposedToPutHere
force-pushed
the
port-publish
branch
from
7d4bbbf to
3a16ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ability to configure the set of published ports via command line switches.
This is a continuation from #134 that moves all internal communications to vsock ports.