Updating the integration test harness to handle zipfile inputs as tests #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingbolt
suggested changes
Feb 10, 2025
|
|
||
| new_proto_input_paths = [] | ||
| for proto_input_path in proto_input_paths: | ||
| zip_path = os.path.join(zipped_input_dir, os.path.basename(proto_input_path) + ".taco") |
There was a problem hiding this comment.
I think we want to use ".guildpoint" for zipped proto files.
There was a problem hiding this comment.
Good catch, I keep forgetting. Were we going to use .guildpoint for the zipped files or something like .burrito. I feel like we keep having this conversation because I keep forgetting.
There was a problem hiding this comment.
Oh you are right it was guildpoint for the file and burrito for the "wrapper"
| zipped_input_dir = os.path.join(temp_directory_path, "zipped_inputs", testcase.name) | ||
| os.makedirs(zipped_input_dir, exist_ok=True) | ||
|
|
||
| new_xml_input_paths = [] |
There was a problem hiding this comment.
I think this should have a typing of List[str]
| find_and_replace_tokens[xml_input_path] = zip_path | ||
| xml_input_paths = new_xml_input_paths | ||
|
|
||
| new_proto_input_paths = [] |
There was a problem hiding this comment.
I think this should have a typing of List[str]
klingbolt
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some indentation formatting, and diff coloring that I wanted to add to get better visuals when trying to test zip file support.