Adding an ability to parse the xml_converter duplicate category output #406
Conversation
identify_duplicate_categories.gd
Outdated
| # | ||
| # A helper function to see if a string starts with a paticular value or not. | ||
| ################################################################################ | ||
| static func starts_with(value: String, prefix: String): |
There was a problem hiding this comment.
There is a String function called begins_with that I think does what this function does. https://docs.godotengine.org/en/3.3/classes/class_string.html#class-string-method-begins-with
There was a problem hiding this comment.
Excellent, I got tunnel vision searching for starts_with.
| var file_name = line.substr(8) | ||
| colisions[category].append(file_name) | ||
| elif starts_with(line, " "): | ||
| var line_without_prefix = line.substr(5) |
There was a problem hiding this comment.
Could you leave a comment that this is removing 4 spaces and the leading quotation mark? It wasn't clear on my first read-through.
identify_duplicate_categories.gd
Outdated
| static func get_duplicate_categories(stdin: String): | ||
| var lines: PoolStringArray = stdin.split("\n") | ||
| var capturing: bool = false | ||
| var colisions = {} |
There was a problem hiding this comment.
Collisions is spelled incorrectly
identify_duplicate_categories.gd
Outdated
| ################################################################################ | ||
| # get_duplicate_categories | ||
| # | ||
| # Parses the stdout of the xml_converter and extracts any category colisions if |
There was a problem hiding this comment.
Collisions is spelled incorrectly
| # | ||
| # Parses the stdout of the xml_converter and extracts any category colisions if | ||
| # there are any that exist. | ||
| ################################################################################ |
There was a problem hiding this comment.
It might be worth adding an example here of what we expect to parse so that if it ever breaks, we have something to compare against. Especially since we do not have integration tests for this code.
Co-authored-by: klingbolt <[email protected]>
Co-authored-by: klingbolt <[email protected]>
Co-authored-by: klingbolt <[email protected]>
This adds the ability to parse the xml_converter output to detect when it reports that a duplicate category has been detected.