closes AST-2786

AstariaXYZ · Jan 10, 2024 · 235f7b4 · 235f7b4
1 parent 7f1d2ca
commit 235f7b4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -139,8 +139,8 @@ TestStarport:testTokenNoCodeCollateral() (gas: 150695)
 TestStarport:testTokenNoCodeDebt() (gas: 180946)
 TestStarport:testUnpause() (gas: 17341)
 TestStrategistOriginator:testEncodeWithAccountCounter() (gas: 12307)
-TestStrategistOriginator:testGetStrategistData() (gas: 1511582)
-TestStrategistOriginator:testIncrementCounterAsStrategist() (gas: 18676)
+TestStrategistOriginator:testGetStrategistData() (gas: 1513389)
+TestStrategistOriginator:testIncrementCounterAsStrategist() (gas: 38723)
 TestStrategistOriginator:testIncrementCounterNotAuthorized() (gas: 13401)
 TestStrategistOriginator:testInvalidCollateral() (gas: 210503)
 TestStrategistOriginator:testInvalidDeadline() (gas: 216182)

diff --git a/src/originators/StrategistOriginator.sol b/src/originators/StrategistOriginator.sol
@@ -147,7 +147,7 @@ contract StrategistOriginator is Ownable, Originator {
         if (msg.sender != strategist && msg.sender != owner()) {
             revert NotAuthorized();
         }
-        _counter += uint256(blockhash(block.number - 1) >> 0x80);
+        _counter += 1 + uint256(blockhash(block.number - 1) >> 0x80);
         emit CounterUpdated(_counter);
     }
 

diff --git a/test/unit-testing/TestStrategistOriginator.sol b/test/unit-testing/TestStrategistOriginator.sol
@@ -49,7 +49,7 @@ contract TestStrategistOriginator is StarportTest, DeepEq {
     }
 
     function testIncrementCounterAsStrategist() public {
-        uint256 newCounter = SO.getCounter() + uint256(blockhash(block.timestamp - 1) << 0x80);
+        uint256 newCounter = SO.getCounter() + 1 + uint256(blockhash(block.timestamp - 1) << 0x80);
         vm.expectEmit();
         emit CounterUpdated(newCounter);
         vm.prank(strategist.addr);