Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased test coverage and remove low-severity compiler warnings #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0xCooki
Copy link

@0xCooki 0xCooki commented May 15, 2024

TLDR: Increased test coverage, and removed all low-severity compiler warnings.

GM GM

My name is William Ridge (a.k.a Cooki), and if I may be so bold, I have some minor amendments to this Starport repo for your consideration.

Increased Test Coverage

This pull request increases test coverage for src/Custodian.sol and src/Starport.sol respectively to 100% for Lines, Statements, and Functions. Branches remain only partially covered; however I believe this results from a quirk of Foundry, moreso than a fault of the testing suite, although I may be mistaken about this (consult here for more information)

Before

before

After

after

Removed All Low-Severity Compiler Warnings

This pull request also removes many low-severity compiler warnings including: Warning (2072): Unused local variable, Warning (5667): Unused function parameter, Warning (2519): This declaration shadows an existing declaration, Warning (3420): Source file does not specify required compiler version, and Warning (1878): SPDX license identifier not provided in source file. Wherever possible I have attempted to keep as much of the original code untouched as possible, while also addressing these warnings. Stylistically, the modifications to src/Custodian.sol were inspired by this suggestion.

Thank You

Finally, thank you for your time! I very much appreciate the Astaria product, and it was a pleasure to work on this repo. If there are aspects of this pull request you are unhappy with please don't hesitate to let me know, and I will seek to address them.

Moreover, if there is any more ongoing work available that I might contribute to, please consider me for such a role, I would very much like to be an active contributor if possible. Thank you again.

@0xCooki 0xCooki changed the title Cooki Bytes Increased test coverage and remove low-severity compiler warnings May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant