Increased test coverage and remove low-severity compiler warnings #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Increased test coverage, and removed all low-severity compiler warnings.
GM GM
My name is William Ridge (a.k.a Cooki), and if I may be so bold, I have some minor amendments to this Starport repo for your consideration.
Increased Test Coverage
This pull request increases test coverage for
src/Custodian.sol
andsrc/Starport.sol
respectively to 100% for Lines, Statements, and Functions. Branches remain only partially covered; however I believe this results from a quirk of Foundry, moreso than a fault of the testing suite, although I may be mistaken about this (consult here for more information)Before
After
Removed All Low-Severity Compiler Warnings
This pull request also removes many low-severity compiler warnings including:
Warning (2072): Unused local variable
,Warning (5667): Unused function parameter
,Warning (2519): This declaration shadows an existing declaration
,Warning (3420): Source file does not specify required compiler version
, andWarning (1878): SPDX license identifier not provided in source file
. Wherever possible I have attempted to keep as much of the original code untouched as possible, while also addressing these warnings. Stylistically, the modifications tosrc/Custodian.sol
were inspired by this suggestion.Thank You
Finally, thank you for your time! I very much appreciate the Astaria product, and it was a pleasure to work on this repo. If there are aspects of this pull request you are unhappy with please don't hesitate to let me know, and I will seek to address them.
Moreover, if there is any more ongoing work available that I might contribute to, please consider me for such a role, I would very much like to be an active contributor if possible. Thank you again.